-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wizard recipe: Chemfiles-v0.9.2 #366
Merged
giordano
merged 4 commits into
JuliaPackaging:master
from
Luthaf:wizard/Chemfiles-v0.9.2_b9328f5c
Jan 8, 2020
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
# Note that this script can accept some limited command-line arguments, run | ||
# `julia build_tarballs.jl --help` to see a usage message. | ||
using BinaryBuilder, Pkg | ||
|
||
name = "Chemfiles" | ||
version = v"0.9.2" | ||
|
||
# Collection of sources required to complete build | ||
sources = [ | ||
"https://github.com/chemfiles/chemfiles/archive/$version.tar.gz" => | ||
"f0a40c8934cffdc8321bed79ded4cb4de5d5366d1f503a95467e294384521e82", | ||
"./bundled", | ||
] | ||
|
||
# Bash recipe for building across all platforms | ||
script = raw""" | ||
cd ${WORKSPACE}/srcdir/chemfiles-*/ | ||
mkdir build && cd build | ||
cmake -DCMAKE_INSTALL_PREFIX=${prefix} -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TARGET_TOOLCHAIN} -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON .. | ||
atomic_patch -p1 ../../patches/fileno_posix.patch | ||
make -j${nproc} | ||
make install | ||
""" | ||
|
||
# These are the platforms we will build for by default, unless further | ||
# platforms are passed in on the command line | ||
platforms = supported_platforms() | ||
|
||
|
||
# The products that we will ensure are always built | ||
products = [ | ||
LibraryProduct("libchemfiles", :libchemfiles) | ||
] | ||
|
||
# Dependencies that must be installed before this package can be built | ||
dependencies = [ | ||
] | ||
|
||
# Build the tarballs, and possibly a `build.jl` as well. | ||
build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
--- a/external/netcdf/libdispatch/dfile.c | ||
+++ b/external/netcdf/libdispatch/dfile.c | ||
@@ -32,7 +32,9 @@ | ||
#ifdef HAVE_STDIO_H | ||
#include <stdio.h> | ||
#endif | ||
+#ifdef __USE_POSIX | ||
extern int fileno(FILE*); | ||
+#endif | ||
|
||
#include "ncdispatch.h" | ||
#include "netcdf_mem.h" | ||
--- a/external/netcdf/libdispatch/dparallel.c | ||
+++ b/external/netcdf/libdispatch/dparallel.c | ||
@@ -10,7 +10,9 @@ | ||
#ifdef HAVE_STDIO_H | ||
#include <stdio.h> | ||
#endif | ||
+#ifdef __USE_POSIX | ||
extern int fileno(FILE*); | ||
+#endif | ||
|
||
/** | ||
Create a netCDF file for parallel I/O. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for taking the time to do this! Can I incorporate this patch directly in our fork of netcdf? https://github.com/chemfiles/netcdf-c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!