Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add builder for PROPACK #385

Merged
merged 1 commit into from
Jan 17, 2020
Merged

add builder for PROPACK #385

merged 1 commit into from
Jan 17, 2020

Conversation

dpo
Copy link
Contributor

@dpo dpo commented Jan 14, 2020

No description provided.

@giordano giordano closed this Jan 15, 2020
@giordano giordano reopened this Jan 15, 2020
@giordano
Copy link
Member

You don't need the patch for building a library against OpenBLAS, you can adapt what I did in #388 (comment). If you're not comfortable doing this, I can have a look to this in the next days.

@dpo
Copy link
Contributor Author

dpo commented Jan 16, 2020

Thanks. I thought there should be a better way than the patch but will your trick work with Fortran 77 source code?

@giordano
Copy link
Member

Yes, gfortran uses the same C preprocessor as GCC (even if there isn't a standard Fortran preprocessor, as far as I know). However you need to set FFLAGS, instead of CXXFLAGS. Also ARPACK does this and is in Fortran

@dpo
Copy link
Contributor Author

dpo commented Jan 16, 2020

Much better, thank you.

@giordano
Copy link
Member

Is this because you wanted to build locally only for one platform?

@dpo
Copy link
Contributor Author

dpo commented Jan 16, 2020

I erroneously pushed the script I was using for testing locally. I really want to build for all platforms.

@giordano
Copy link
Member

I really want to build for all platforms.

Sure, no doubt, I just wanted to point out that if you want to build for just a specific platform you don't need to modify the script, just pass the triplet of that platform as argument to the script, as explained in the FAQ

@giordano giordano merged commit 7f794f1 into JuliaPackaging:master Jan 17, 2020
@dpo
Copy link
Contributor Author

dpo commented Jan 18, 2020

if you want to build for just a specific platform you don't need to modify the script, just pass the triplet of that platform as argument to the script, as explained in the FAQ

Just to follow up on this, it would be great if the triplets were listed somewhere. It wasn't obvious to me that MacOS(:x86_64) is in fact x86_64-apple-darwin14.

@giordano
Copy link
Member

julia> using BinaryBuilder

julia> for p in supported_platforms()
           println("$(p): $(triplet(p))")
       end
Linux(:i686, libc=:glibc): i686-linux-gnu
Linux(:x86_64, libc=:glibc): x86_64-linux-gnu
Linux(:aarch64, libc=:glibc): aarch64-linux-gnu
Linux(:armv7l, libc=:glibc, call_abi=:eabihf): arm-linux-gnueabihf
Linux(:powerpc64le, libc=:glibc): powerpc64le-linux-gnu
Linux(:i686, libc=:musl): i686-linux-musl
Linux(:x86_64, libc=:musl): x86_64-linux-musl
Linux(:aarch64, libc=:musl): aarch64-linux-musl
Linux(:armv7l, libc=:musl, call_abi=:eabihf): arm-linux-musleabihf
MacOS(:x86_64): x86_64-apple-darwin14
FreeBSD(:x86_64): x86_64-unknown-freebsd11.1
Windows(:i686): i686-w64-mingw32
Windows(:x86_64): x86_64-w64-mingw32

😉

@dpo
Copy link
Contributor Author

dpo commented Jan 18, 2020

Thanks. That would fit just right in the docs somewhere ;-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants