Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROJ build new minor version 6.3.0 #394

Merged
merged 4 commits into from
Jan 18, 2020

Conversation

visr
Copy link
Contributor

@visr visr commented Jan 16, 2020

@visr
Copy link
Contributor Author

visr commented Jan 16, 2020

Hmm 1 is failing, only powerpc64le-linux-gnu-cxx11.

The log blames libsqlite:

[14:55:20] /opt/powerpc64le-linux-gnu/bin/../lib/gcc/powerpc64le-linux-gnu/5.2.0/../../../../powerpc64le-linux-gnu/bin/ld: warning: libdl.so.2, needed by /workspace/destdir/lib/libsqlite3.so, not found (try using -rpath or -rpath-link)
[14:55:20] /workspace/destdir/lib/libsqlite3.so: undefined reference to `dlerror@GLIBC_2.17'
[14:55:20] /workspace/destdir/lib/libsqlite3.so: undefined reference to `dlclose@GLIBC_2.17'
[14:55:20] /workspace/destdir/lib/libsqlite3.so: undefined reference to `dlopen@GLIBC_2.17'
[14:55:20] /workspace/destdir/lib/libsqlite3.so: undefined reference to `dlsym@GLIBC_2.17'
[14:55:20] collect2: error: ld returned 1 exit status

Not sure what's wrong. The SQLite build is from Oct 18, 2019. Maybe it's just time for a new SQLite build with a newer BinaryBuilder? The SQLite version is still the latest.

https://github.com/JuliaBinaryWrappers/SQLite_jll.jl/releases/tag/SQLite-v3.30.1%2B0

@giordano
Copy link
Member

RootFS.md, which however is not very up-to-date, says that PowerPC uses glibc 2.25, indeed I can see these symbols in libsqlite:

shell> nm $(SQLite_jll.libsqlite_path)
[...]
                 U write@@GLIBC_2.2.5
[...]
                 U __xstat64@@GLIBC_2.2.5
[...]

There have been changes to PowerPC recently, maybe the glibc version associated with it changed, so yes, this package may require a new build, but Elliot can tell us more.

@giordano
Copy link
Member

While we are at it, maybe you can replace

cmake --build .

with

make -j${nproc}

? This slightly speeds up compilation.

@visr
Copy link
Contributor Author

visr commented Jan 17, 2020

Unfortunately using a freshly baked SQLite_jll v3.30.1+1 did not resolve the issue. Perhaps @staticfloat has a clue what's wrong with the powerpc64le-linux-gnu-cxx11 build.

@giordano
Copy link
Member

Now that I reread my message, it doesn't make any sense: I used for testing SQLite for my architecture, which isn't PowerPC.

Looking better also to the error message I think you may need to link against libdl, so that you need to add -ldl to the command line invocation, for example by adding dl to the CMAKE_REQUIRED_LIBRARIES at line 148 of the CMake file:

set(CMAKE_REQUIRED_LIBRARIES dl m)

To fix errors like
```
/workspace/destdir/lib/libsqlite3.so: undefined reference to `dlerror@GLIBC_2.17'
```
on `powerpc64le-linux-gnu-cxx11`.
@visr
Copy link
Contributor Author

visr commented Jan 17, 2020

Ah ok, thanks. This is the first time I'm creating such a patch, so I just tried copying from the other examples. Is a workflow for how to create and apply these patches documented somewhere?

Locally this fixed powerpc64le-linux-gnu-cxx11 for me :)

@visr visr closed this Jan 17, 2020
@visr visr reopened this Jan 17, 2020
@giordano
Copy link
Member

Is a workflow for how to create and apply these patches documented somewhere?

https://juliapackaging.github.io/BinaryBuilder.jl/dev/build_tips/#Editing-files-in-the-wizard-1 but that's just one way of doing it. I have a completely different workflow, which I don't know if I want to document because it's extremely convoluted and inefficient, I don't think anyone would benefit from knowing it

@giordano
Copy link
Member

Sorry, I was expecting that CMake could do something reasonable, what a blunder. I went ahead and worked around with a more direct setting.

@giordano giordano merged commit 1583b96 into JuliaPackaging:master Jan 18, 2020
@visr visr deleted the new-proj-version branch June 2, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants