Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SHOT] v1.1 and build on experimental platforms #4024

Merged
merged 6 commits into from
Dec 6, 2021
Merged

[SHOT] v1.1 and build on experimental platforms #4024

merged 6 commits into from
Dec 6, 2021

Conversation

odow
Copy link
Contributor

@odow odow commented Dec 5, 2021

No description provided.

@giordano
Copy link
Member

giordano commented Dec 5, 2021

You probably don't need to update the SDK for aarch64-apple-darwin

@odow @giordano
Update C/Coin-OR/SHOT/build_tarballs.jl
7e3b288 
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
@odow
Copy link
Contributor Author

odow commented Dec 5, 2021

I'm not that sad if we can't build SHOT on the M1: phracker/MacOSX-SDKs#41

I'm surprised we made it this far through the COIN-OR stack before finding a problem!

@giordano
Copy link
Member

giordano commented Dec 5, 2021

But we use the 11.1 SDK on that platform:

Yggdrasil/0_RootFS/gcc_common.jl

Line 240 in 0173b33

ArchiveSource("https://github.com/phracker/MacOSX-SDKs/releases/download/11.0-11.1/MacOSX11.1.sdk.tar.xz",

I don't understand the error, there may be something else wrong going on.

@odow odow closed this Dec 5, 2021
@odow odow deleted the od/SHOT branch December 5, 2021 19:45
@odow odow restored the od/SHOT branch December 5, 2021 19:45
@odow odow reopened this Dec 5, 2021
@giordano giordano merged commit 4f873b9 into JuliaPackaging:master Dec 6, 2021
@odow odow deleted the od/SHOT branch December 6, 2021 01:48
@odow
Copy link
Contributor Author

odow commented Dec 6, 2021

Thanks @giordano! 20 PRs later and we made it through the COIN-OR stack with very few issues, which I was not expecting...

@giordano
Copy link
Member

giordano commented Dec 6, 2021

For the record, we are getting the wrong minimum macOS version from the wrappers for aarch64-apple-darwin, that's why this was failing here. This is (hopefully) going to be fixed by JuliaPackaging/BinaryBuilderBase.jl#193.

Thanks @giordano! 20 PRs later and we made it through the COIN-OR stack with very few issues, which I was not expecting...

Maybe we have a robust toolchain at this point 😜

simeonschaub pushed a commit to simeonschaub/Yggdrasil that referenced this pull request Feb 23, 2022
@odow @giordano @simeonschaub
[SHOT] v1.1 and build on experimental platforms (JuliaPackaging#4024)
28af32e 
* [SHOT] v1.1 and build on experimental platforms

* Update coin-or-common.jl

* Update build_tarballs.jl

* Update C/Coin-OR/SHOT/build_tarballs.jl

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

* Update build_tarballs.jl

* [SHOT] Fix compilation for `aarch64-apple-darwin`

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
Co-authored-by: Mosè Giordano <mose@gnu.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odow @giordano