Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HDF5] Also include dll.a in the output on Windows #5426

Merged
merged 4 commits into from
Sep 4, 2022
Merged

[HDF5] Also include dll.a in the output on Windows #5426

merged 4 commits into from
Sep 4, 2022

Conversation

evetion
Copy link
Contributor

@evetion evetion commented Sep 4, 2022

As it might make #5383 build on Windows

@evetion
Copy link
Contributor Author

evetion commented Sep 4, 2022

The output on Windows now includes

libhdf5-0.dll
libhdf5.dll.a  # new
libhdf5_hl-0.dll
libhdf5_hl.dll.a  # new
libhdf5_tools-0.dll
libhdf5_tools.dll.a  # new

giordano
giordano reviewed Sep 4, 2022
View reviewed changes
H/HDF5/build_tarballs.jl Outdated Show resolved Hide resolved
H/HDF5/build_tarballs.jl Outdated Show resolved Hide resolved
@evetion evetion marked this pull request as ready for review September 4, 2022 11:44
@giordano giordano merged commit 86f01f3 into JuliaPackaging:master Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evetion @giordano