[GDAL] Use NetCDF and HDF5 when available. #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
Sep 11, 2022
giordano
reviewed
Sep 11, 2022
giordano
reviewed
Sep 11, 2022
giordano
reviewed
Sep 11, 2022
visr
approved these changes
Sep 11, 2022
giordano
reviewed
Sep 11, 2022
G/GDAL/build_tarballs.jl
Outdated
Comment on lines
110
to
111
| Dependency("NetCDF_jll"; compat="400.902.5"), | ||
| Dependency("HDF5_jll"), |
There was a problem hiding this comment.
Since these packages aren't available on all platforms, I'd prefer to use them only when available, which would also clear the dozens of warnings about these packages not being available: https://dev.azure.com/JuliaPackaging/Yggdrasil/_build/results?buildId=22093&view=results. Filtering them properly though is a bit tricky, but I don't have the time to do it now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@visr
Fixes #4950 (at least partially).
Uses the same approach as #5383, by only using NetCDF and HDF5 on the platforms where they are available. While this introduces a disparity between platforms, it helps the most common platforms (Windows, macOS, Linux gnu).
Platforms without HDF5 and NetCDF