-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LLVMLibUnwind] Add version 14.0.6 #6041
Conversation
CC @gbaraldi in case this helps with JuliaLang/julia#48020 |
I tried just building from the LLVM repo, but I guess I'm missing some patches, so when yggdrasil is back soon ™️ I will try this out. |
Building this in codespaces I get
|
For the record, compilation is successful, at least for aarch64-apple-darwin, if using as source the full llvm-project tarball, instead of the single libunwind one. |
Does that mean we should actually try again to do #3540? 😱 Or is it sufficient to switch from using the standalone source tarball for libunwind to the full LLVM one? For 12.0.1 I added a bundled patch that reverts the commit that disallowed standalone builds, but enough has changed since then that it'd be a real pain to adapt that patch. That's why for this one I just added a patch that deletes the error at the top and hoped for the best... |
I downloaded the llvm-project tarball and it worked out smoothly. I did it inside the build environment, I didn't update the build script locally, but it shouldn't be too hard |
16fad8f
to
e59410e
Compare
#ifndef __DWARF_PARSER_HPP__ | ||
#define __DWARF_PARSER_HPP__ | ||
|
||
+#define __STDC_FORMAT_MACROS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They use it elsewhere, but not in libunwind: https://github.com/llvm/llvm-project/blob/5d87f60f894764bd435086e311605884638d2384/libcxx/include/inttypes.h#L244-L249
…ailable Fixes errors like ``` /workspace/srcdir/llvm-project-14.0.6.src/libunwind/src/DwarfParser.hpp:675:66: error: expected ‘)’ before ‘PRIu64’ ```
e59410e
to
83aa2bc
Compare
Edit: you already fixed it ❤️ |
Should be fixed by 3ad149b#diff-3358a3924953c17aa8cedfd626863e654e065c5c0bc1f087fe462d13514c998aR63 |
@gbaraldi worth another try now I think 🙂 |
No description provided.