-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[terminfo-db] Add a builder for the terminfo database #9165
Conversation
This uses the directory-based database rather than the single Berkeley database (terminfo.db). The license is from ncurses, which is close enough; see https://invisible-island.net/ncurses/terminfo.src.html. Ideally this would be shipped as one of Julia's dependencies to ensure that the custom terminfo parser actually works on all platforms, as not all have the terminfo database.
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make log more verbose.
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
I'm confused now: |
I wish I knew... |
Okay wtf:
But then
and
|
Am I going crazy or does this make no sense? (I guess those aren't mutually exclusive...) Also very possible that how I've gone about the case handling is incorrect but it seems like it should work as written. |
For the record, it turns out the database contains lots of hardlinked files which share the same inodes (you can check it out with |
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
# I'd rather not list out >2k individual `FileProduct`s so let's just call the entry | ||
# for xterm our "product" and hope the rest are there | ||
products = [ | ||
FileProduct("share/terminfo/x/xterm", :terminfo_xterm), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can share/terminfo
be the "file" product?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think that'd work as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does versioning work if we change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't change the version number, Pkg will only install the latest one.
This uses the directory-based database rather than the single Berkeley database (terminfo.db). The license is from ncurses, which is close enough; see https://invisible-island.net/ncurses/terminfo.src.html.
Ideally this would be shipped as one of Julia's dependencies to ensure that the custom terminfo parser actually works on all platforms, as not all have the terminfo database.