Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slurm Docker tests #154

Merged
merged 4 commits into from
Oct 7, 2021
Merged

Add Slurm Docker tests #154

merged 4 commits into from
Oct 7, 2021

Conversation

simonbyrne
Copy link
Member

Start on #105, alternative to #125

Uses container from https://github.com/giovtorres/docker-centos7-slurm

@simonbyrne simonbyrne force-pushed the sb/unittests branch 2 times, most recently from af5f7b1 to 8a47b27 Compare November 25, 2020 18:19
@kescobo
Copy link
Collaborator

kescobo commented Nov 25, 2020

Oh, awesome - this will be great!

@simonbyrne
Copy link
Member Author

simonbyrne commented Nov 25, 2020

Note that this runs both the compute daemon and the scheduler in the same container, so it may not be the most realistic use case.

For something more advanced there is https://github.com/giovtorres/slurm-docker-cluster, but I don't really know enough about containers to figure out how to use it. @kleinhenz used something like this in the CI for https://github.com/kleinhenz/SlurmClusterManager.jl

@kleinhenz
Copy link

My testing setup uses https://github.com/kleinhenz/docker-slurm-cluster which was adapted from https://github.com/giovtorres/slurm-docker-cluster by removing as much complexity as possible (most notably the database features). I'm not sure how important it is to have the compute nodes isolated but I guess it would make it a bit more realistic.

@kescobo
Copy link
Collaborator

kescobo commented Oct 6, 2021

Is there anything keeping this from being merged? Would be really nice to have this going forward, I think.

@simonbyrne simonbyrne merged commit b520580 into master Oct 7, 2021
@simonbyrne simonbyrne deleted the sb/unittests branch October 7, 2021 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants