allow declaration of custom operations at precompilation #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
reviewed
Jul 8, 2020
| const op = Op(OP_NULL.val, nothing) | ||
| const $(esc(opwrap)) = OpWrapper{typeof($(esc(f))),$(esc(T))}($(esc(f))) | ||
| function initop() | ||
| fptr = @cfunction($opwrap, Cvoid, (Ptr{Cvoid}, Ptr{Cvoid}, Ptr{Cint}, Ptr{MPI_Datatype})) |
There was a problem hiding this comment.
Yes that should work with PPC. It is the dynamic version of @cfunction that requires an LLVM feature that doesn't work on PPC.
|
Is there any way we could do this without a macro, e.g. via a generated function? I don't see how because of the |
|
Would this fix #404 also for the M1? If yes, is there anything I can do to help getting it merged? |
|
Also interested in this, since a few packages I use depend on MPI.jl (M1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #404.
needs tests.
@vchuravy would this work on PPC? We should set up a CI build now that Travis supports PPC.