Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPIPreferences] add functions to check (and error) if the MPI implementation has changed #670

Merged
merged 5 commits into from
Oct 6, 2022

Conversation

simonbyrne
Copy link
Member

Currently call @warn if the MPI implementation has changed: in general I don't like using @warn unless something is bad.

Instead it will now use @info to print the information, but throws an error if MPI is already loaded, or is loaded subsequently.

It also modifies the message from #641 to be a warning (since that presumably is bad).

Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed this should be an info, not a warning. I only have a comment about whether to check if the preferences actually changed

lib/MPIPreferences/src/MPIPreferences.jl Outdated Show resolved Hide resolved
@simonbyrne
Copy link
Member Author

Okay, if we're on board with this, the question is does this need a 0.2 bump of MPIPreferences? if so, do i need to rebuild all the binaries?

@giordano
Copy link
Member

giordano commented Oct 6, 2022

I don't think there is anything breaking, is there?

@simonbyrne
Copy link
Member Author

I guess not? We will need to bump the version requirement in MPI.jl though.

@simonbyrne simonbyrne merged commit 0965740 into master Oct 6, 2022
@simonbyrne simonbyrne deleted the sb/check-unchanged branch October 6, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants