increase timeout #676
Closed
increase timeout #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbyrne
force-pushed
the
sb/timeout
branch
from
639fed9 to
c8d1aeb
Compare
|
I think we need to call MPI.Abort from our atexit hook |
simonbyrne
commented
Nov 6, 2022
Comment on lines
+106
to
+110
| if ccall(:jl_current_exception, Any, ()) === nothing | ||
| Finalize() | ||
| else | ||
| Abort(MPI.COMM_WORLD, 1) | ||
| end |
There was a problem hiding this comment.
@vchuravy does this seem okay to you?
There was a problem hiding this comment.
Actually, failures seem to be only on nightly: did jl_current_exception change?
|
Yup, it's an issue on nightly: JuliaLang/julia#47472 |
|
Fixed now in #680 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.