Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mpiexecjl for windows #783

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
small fixes for tests
guilhermebodin committed Oct 17, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 98c24a08caf17b0f7b8051f3927e689106d23eff
2 changes: 1 addition & 1 deletion .github/workflows/ShellCheck.yml
Original file line number Diff line number Diff line change
@@ -26,4 +26,4 @@ jobs:
- name: Install dependencies
run: sudo apt install shellcheck
- name: Check scripts
run: shellcheck bin/*
run: shellcheck bin/mpiexecjl_unix
6 changes: 3 additions & 3 deletions test/mpiexecjl.jl
Original file line number Diff line number Diff line change
@@ -24,9 +24,9 @@ using MPI
end

additional_initial_parts_cmd = if Sys.isunix()
[""]
String[]
else
["powershell.exe", "-ExecutionPolicy", "Bypass", "-File"]
String["powershell.exe", "-ExecutionPolicy", "Bypass", "-File"]
end

# `Base.julia_cmd()` ensures keeping consistent flags when running subprocesses.
@@ -40,7 +40,7 @@ using MPI
# Test help messages
for help_flag in ("-h", "--help")
help_message = withenv(env...) do
read(`$(additional_initial_parts_cmd) $(mpiexecjl) --project=$(dir) --help`, String)
read(`$(additional_initial_parts_cmd) $(mpiexecjl) --project=$(dir) $help_flag`, String)
end
@test occursin(r"Usage:.*MPIEXEC_ARGUMENTS", help_message)
end