Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMDGPU compat #839

Closed
wants to merge 1 commit into from
Closed

AMDGPU compat #839

wants to merge 1 commit into from

Conversation

ahojukka5
Copy link

Bump compat to latest 0.9 release.

@luraess
Copy link
Contributor

luraess commented Jun 19, 2024

Thanks. Could you also bump the compat in the Project.toml from test folder?

Bump compat to latest 0.9 release.
@ahojukka5
Copy link
Author

There you go.

@luraess
Copy link
Contributor

luraess commented Jun 19, 2024

Thanks

@giordano
Copy link
Member

giordano commented Jun 19, 2024

Tests seem broken in Julia v1.6 now:

     Testing Running tests...
ERROR: LoadError: LoadError: ArgumentError: Package Polynomials does not have MakieCore in its dependencies:
- If you have Polynomials checked out for development and have
  added MakieCore as a dependency but haven't updated your primary
  environment's manifest file, try `Pkg.resolve()`.
- Otherwise you may need to report an issue with Polynomials

Edit: ah, that was JuliaMath/Polynomials.jl#575 (comment) (fixed by JuliaMath/Polynomials.jl#577), clearing the cache to allow installation of newer version seems to have solved the issue.

@luraess
Copy link
Contributor

luraess commented Jun 19, 2024

Seems all good now, except the GPU-aware tests which fails (unrelated to this PR as reported by @giordano). Shall we bump and patch release and take care of the GPU CI in another PR?

@vchuravy
Copy link
Member

Did someone confirm that this is fine locally?

@luraess
Copy link
Contributor

luraess commented Jun 19, 2024

Did someone confirm that this is fine locally?

I was in the process but getting stuck as on a cluster under SLURM I did not manage to allocate resources that could be spawned by running MPI test suite from within the test suite... This is a recurring issue one is hitting and I did not find a work-around yet. It would be different on a multi-GPU server node where one could just run mpiexec without SLURM with all devices visible, etc...

@vchuravy
Copy link
Member

@ahojukka5 thank you for your PR. I will close this in favor of #844

@vchuravy vchuravy closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants