Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust lower compats for compatibility with julia-1.11 #419

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fhagemann
Copy link
Collaborator

Here are some changes to the lower package compats required to work on julia-1.11:

In addition, the impossibility of running Geant4 tests on x86 causes the tests that were previously passing to fail. Therefore, I explicitly removed Geant4 from test/Project.toml in the x86 test.

@fhagemann fhagemann added the dependencies Pull requests that update a dependency file label Oct 9, 2024
@fhagemann
Copy link
Collaborator Author

fhagemann commented Oct 9, 2024

@oschulz The tests now pass using julia-1.11, but are significantly slower..
(< 30min on julia-1.10, > 60min on julia-1.11)

@fhagemann fhagemann marked this pull request as draft October 9, 2024 22:24
@oschulz
Copy link
Member

oschulz commented Oct 10, 2024

The tests now pass using julia-1.11, but are significantly slower.

Let's see if we can reproduce (and then benchmark and investigate) this locally.

@fhagemann fhagemann marked this pull request as ready for review October 19, 2024 08:28
@fhagemann fhagemann marked this pull request as draft October 19, 2024 08:28
@fhagemann fhagemann marked this pull request as ready for review October 19, 2024 09:58
@fhagemann fhagemann marked this pull request as draft October 19, 2024 10:23
@fhagemann fhagemann marked this pull request as ready for review November 18, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants