-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First pass at updating API for allowing animations #339
base: master
Are you sure you want to change the base?
Conversation
I see that the Labeler is failing, is there a way I can address this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making an attempt at this! It will be a welcome and helpful contribution.
I have one question about the change to calling the javascript Plotly.newPlot
function, but other than that this looks great.
src/display.jl
Outdated
@@ -97,7 +97,7 @@ function SyncPlot( | |||
|
|||
# Draw plot in container | |||
Plotly.newPlot( | |||
gd, $(lowered[:data]), $(lowered[:layout]), $(options) | |||
gd, $(lowered), $(options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work as expected?
From the plotly.js docs (ref) it looks like we can use one of two forms of the newPlot
function:
Plotly.newPlot(graphDiv, data, layout, config)
Plotly.newPlot(graphDiv, obj)
Here I don't believe we are using either
I looked at the documentation, and I believe you caught a mistake. I have fixed the call in the most recent commit. |
Now that the PlotlyBase side has been merged, hopefully I'll be able to review this one soon. Thanks for the contributions and for the patience! |
Dr. Lyon,
Regards, |
Update display function to allow for frames for animation, and add animation example