minorticks consistency

JuliaPlots · Nov 19, 2022 · b4c2ab9 · b4c2ab9
1 parent 1a4c45f
commit b4c2ab9
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 7 deletions.
diff --git a/src/axes.jl b/src/axes.jl
@@ -322,11 +322,17 @@ _transform_ticks(ticks::NTuple{2,Any}, axis) = (_transform_ticks(ticks[1], axis)
 
 const DEFAULT_MINOR_TICKS = Ref(4)
 
+function no_minor_ticks(axis)
+    (n_minor_ticks = axis[:minorticks]) === false && return true  # must be tested with `===` since Bool <: Integer
+    n_minor_ticks ∈ (:none, nothing) && return true
+    (n_minor_ticks === :auto && !axis[:minorgrid]) && return true
+    false
+end
+
 function get_minor_ticks(sp, axis, ticks_and_labels)
-    (n_minor_ticks = axis[:minorticks]) === false && return  # must be tested with `===` since Bool <: Integer
-    n_minor_ticks ∈ (:none, nothing) && return
-    (n_minor_ticks === :auto && !axis[:minorgrid]) && return nothing
+    no_minor_ticks(axis) && return
 
+    n_minor_ticks = axis[:minorticks]
     ticks = first(ticks_and_labels)
     length(ticks) < 2 && return
 

diff --git a/src/backends/pgfplotsx.jl b/src/backends/pgfplotsx.jl
@@ -1240,7 +1240,7 @@ function pgfx_axis!(opt::Options, sp::Subplot, letter)
                         axis[:minorgridalpha],
                         axis[:minorgridstyle],
                     ),
-                    if (mt = axis[:minorticks]) > 1 && typeof(mt) <: Integer || mt
+                    if length(minor_ticks) > 0
                         "major tick length" => "0.1cm"
                     else
                         "major tick length" => "0"

diff --git a/src/backends/pyplot.jl b/src/backends/pyplot.jl
@@ -1263,9 +1263,10 @@ function _before_layout_calcs(plt::Plot{PyPlotBackend})
                 pyaxis."grid"(false)
             end
 
-            if axis[:minorticks] > 1
+            if !no_minor_ticks(axis) && axis[:minorticks] <: Integer
                 pyaxis."set_minor_locator"(
-                    PyPlot.matplotlib.ticker.AutoMinorLocator(axis[:minorticks]),
+                    # NOTE: AutoMinorLocator expects a number of intervals == number of ticks + 1
+                    PyPlot.matplotlib.ticker.AutoMinorLocator(axis[:minorticks] + 1),
                 )
                 pyaxis."set_tick_params"(
                     which = "minor",
@@ -1276,7 +1277,7 @@ function _before_layout_calcs(plt::Plot{PyPlotBackend})
             end
 
             if axis[:minorgrid]
-                axis[:minorticks] > 1 || ax."minorticks_on"()  # Check if ticks were already configured
+                no_minor_ticks(axis) || ax."minorticks_on"()  # Check if ticks were already configured
                 pyaxis."set_tick_params"(
                     which = "minor",
                     direction = axis[:tick_direction] === :out ? "out" : "in",