Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GR: 3D, warn on invalid rotation or tilt #3590

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Jul 1, 2021

Invalid rotation or tilt are currently silently ignored in GR, I believe the user should be warned.

This is a wontfix from Plots.jl's side, users should open an issue or PR in https://github.com/sciapp/gr for supporting θ < 0 or θ > 90.

See https://gr-framework.org/julia-gr.html#GR.setspace-0880646251e9db0f5d16f4369795d314:

Angles of rotation and viewing angle must be specified between 0° and 90°.

Linked #3541.
Fixes #3445.
Fixes #1911.

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #3590 (1ddc673) into master (bba971f) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3590      +/-   ##
==========================================
- Coverage   65.12%   65.03%   -0.09%     
==========================================
  Files          27       27              
  Lines        6660     6663       +3     
==========================================
- Hits         4337     4333       -4     
- Misses       2323     2330       +7     
Impacted Files Coverage Δ
src/backends/gr.jl 88.65% <100.00%> (+0.03%) ⬆️
src/axes.jl 83.56% <0.00%> (-0.47%) ⬇️
src/recipes.jl 57.75% <0.00%> (-0.46%) ⬇️
src/layouts.jl 68.06% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba971f...1ddc673. Read the comment docs.

@t-bltg t-bltg requested review from BeastyBlacksmith and daschw July 4, 2021 10:47
@BeastyBlacksmith
Copy link
Member

what if we project the value in the feasible interval?

@t-bltg
Copy link
Member Author

t-bltg commented Jul 5, 2021

what if we project the value in the feasible interval?

We could, that would require flipping & mirroring logic, which I suspect to be 🤯 .
Maybe I'll do that when I'll have time 😉, although this is low right now on my todo list.
In the mean time, with this PR, we close 2 issues and we avoid piling up potential new issues on that matter.

@t-bltg t-bltg added the GR label Jul 5, 2021
Copy link
Member

@daschw daschw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to have this warning. We can think about projecting in a separate PR.

@t-bltg t-bltg merged commit fbd5d79 into JuliaPlots:master Jul 5, 2021
@t-bltg t-bltg deleted the warn branch July 5, 2021 13:01
@hurricane007
Copy link

so basically this "issue" is due to the limitation of GR backend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] camera on GR doesn't work properly GR: camera angles outside [0,90] do not work
4 participants