Handle seriescolor option in pie plot recipe #4208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome 🙂. You may check out #3503, since this is your first contribution. Otherwise this PR looks good to me. It would be a good addition, to add some tests to ensure it stays this way. |
Codecov Report
@@ Coverage Diff @@
## master #4208 +/- ##
=======================================
Coverage 77.88% 77.89%
=======================================
Files 28 28
Lines 7081 7083 +2
=======================================
+ Hits 5515 5517 +2
Misses 1566 1566
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3214.
As described in the issue, the pie recipe didn't handle
seriescolor. This commit adds a couple lines of code to cycle throughseriescolorfor each pie slice.