-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
baseline fix for bar plots using log scales #4503
Conversation
Can't we just set |
Could be a cheap solution too. |
For what is worth, the original data in my example span multiple decades (10 and 100 mainly), reason why I was trying to use logscale |
Codecov ReportBase: 90.65% // Head: 91.05% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4503 +/- ##
==========================================
+ Coverage 90.65% 91.05% +0.39%
==========================================
Files 40 40
Lines 7353 7688 +335
==========================================
+ Hits 6666 7000 +334
- Misses 687 688 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
We could compute global series extrema somewhere here https://github.com/JuliaPlots/Plots.jl/blob/master/RecipesPipeline/src/series_recipe.jl#L10-L29 ... If we choose an arbitrary default value of |
Looks great! And I can still tweak it with fillto if I need, right? |
Yes, as long as |
dc15391
to
949eb23
Compare
Fix #4502.
At least values within the same decade are unified to the same value (decade start).
Would that be better @giordano ?
pr
master
The problem lies in the way we process series.
Can we preprocess a common minimal value before mapping to bar series ?