-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package extensions - weak deps #4649
Conversation
Codecov ReportBase: 90.48% // Head: 90.43% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4649 +/- ##
==========================================
- Coverage 90.48% 90.43% -0.06%
==========================================
Files 41 40 -1
Lines 8801 8700 -101
==========================================
- Hits 7964 7868 -96
+ Misses 837 832 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
389bf30
to
110be6d
Compare
I fail to see:
I cleaned up the actions caches, but it didn't seem to help 🤷 . I guess another look at this (maybe @mkitti, or @BeastyBlacksmith) is necessary. |
Setting the Review comments welcome now. |
I'll probably merge this PR in the next few days, unless new comments are made. |
Fix #4589.
Note that we don't replace the
@require
statements for backends loading since their treatment is somewhat "special":Plots.jl/src/backends.jl
Line 100 in ef50445
I'm unsure this logic can be moved to package extensions (neither if it's worth it).
NOTE: the formatter check failure is investigated in tkf/JuliaProjectFormatter.jl#7.