CI fixes v2 #4980
Merged
CI fixes v2 #4980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update tests for Latexify 0.16.5
Behaviour was changed such that ã becomes \tilde{a}, instead of
\textnormal{\~{a}}.
* Test Julia 1.6 on x86 macOS instead of ARM
See: https://discourse.julialang.org/t/how-to-fix-github-actions-ci-failures-with-julia-1-6-or-1-7-on-macos-latest-and-macos-14/117019
* Bump GR compat and Plots version number
* update plotly show methods for PlotlyKaleido v2
* remove Pkg
* add it back
---------
Co-authored-by: Simon Christ <christ@cell.uni-hannover.de>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #4980 +/- ##
==========================================
+ Coverage 87.06% 87.10% +0.04%
==========================================
Files 51 51
Lines 5999 6003 +4
==========================================
+ Hits 5223 5229 +6
+ Misses 776 774 -2 ☔ View full report in Codecov by Sentry. |
I am totally on board with that |
penelopeysm
force-pushed
the
v2-ci-fixes
branch
from
d556448
to
d7557d2
Compare
|
This should hopefully pass all the tests now! My last commit message will have a bit more detail :) |
- Disabled reference tests 25 and 30, which require StatsPlots support, for all backends (in PlotsBase/src/examples.jl) - Separate tests that are skipped and tests that are known to be broken due to upstream issues - Re-enable reference test 41 as upstream issue has been fixed (JuliaLang/julia#47261) - Disable reference test 50 because of upstream issue (jheinen/GR.jl#550)
penelopeysm
force-pushed
the
v2-ci-fixes
branch
from
d7557d2
to
014c5be
Compare
|
Thats a great help, thank you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port of #4974 for v2. Sorry this took so long for not very much code!
Some tests are failing, though, because GR 0.73.7 on macOS causes some regressions on plotting — specifically reference image #50. I filed an upstream issue here: jheinen/GR.jl#550
In the meantime, I've added #50 to the list of reference tests to not run on macOS.
(I would probably also prefer if that was renamed from
blacklist. It seems that we are using that to denote tests that we don't expect to work — could we use@test_brokenin its place instead? Then we'd also get to know when the test starts working.)Expected
Actual
Attribution
Things to consider