-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conditionally require FreeType
, FileIO
, Unitful
and ImageInTerminal
through weak deps or Requires
#332
Conversation
Codecov ReportBase: 99.80% // Head: 99.80% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #332 +/- ##
=======================================
Coverage 99.80% 99.80%
=======================================
Files 32 34 +2
Lines 2036 2048 +12
=======================================
+ Hits 2032 2044 +12
Misses 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
77a10eb
to
47f3396
Compare
6822761
to
f7904d6
Compare
FreeType
and ImageInTerminal
through weak deps or Requires
FreeType
, FileIO
and ImageInTerminal
through weak deps or Requires
6856beb
to
75cae03
Compare
FreeType
, FileIO
and ImageInTerminal
through weak deps or Requires
FreeType
, FileIO
, Unitful
and ImageInTerminal
through weak deps or Requires
320543d
to
016edc7
Compare
Fix #331.
Saving as
.png
is mostly forPlots
, and not the primary target ofUnicodePlots
so we now makeFreeType
andFileIO
optional.It's also likely
Unitful
is already loaded when you are plotting quantities, so it's unlikely that making it a weak dependency will break anyone's workflow (glue code) even if this is technically breaking ?I guess this will require a major bump ... Thoughts ?As mentioned on slack, making glue package code optional seems to be non breaking in this case so a minor bump is probably sufficient.
I think I'll wait the
1.9.0-beta4
release to merge this PR for the backport of JuliaLang/julia#48352.latency improvements: ~2s, about 32% gain
julia 1.9.0-beta3
pr
master