conditionally require FreeType
, FileIO
, Unitful
and ImageInTerminal
through weak deps or Requires
#332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #331.
Saving as
.png
is mostly forPlots
, and not the primary target ofUnicodePlots
so we now makeFreeType
andFileIO
optional.It's also likely
Unitful
is already loaded when you are plotting quantities, so it's unlikely that making it a weak dependency will break anyone's workflow (glue code) even if this is technically breaking ?I guess this will require a major bump ... Thoughts ?As mentioned on slack, making glue package code optional seems to be non breaking in this case so a minor bump is probably sufficient.
I think I'll wait the
1.9.0-beta4
release to merge this PR for the backport of JuliaLang/julia#48352.latency improvements: ~2s, about 32% gain
julia 1.9.0-beta3
pr
master