Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong bond connections graph behavior #117

Closed
ctrekker opened this issue Jun 7, 2023 · 5 comments
Closed

Wrong bond connections graph behavior #117

ctrekker opened this issue Jun 7, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@ctrekker
Copy link
Member

ctrekker commented Jun 7, 2023

The following notebook will reproduce the issue:
Screenshot from 2023-06-07 12-10-07

The value of f depends on both x and y, implying that x and y are codependent. It seems like PlutoSliderServer's analysis doesn't recognize this:
Screenshot from 2023-06-07 12-13-31

I haven't done much more testing beyond finding this simplified MWE, but it seems this is an issue with codependents and friends, since Pluto calculates the topology of this notebook without any issues.

@ctrekker ctrekker added the bug Something isn't working label Jun 7, 2023
@ctrekker
Copy link
Member Author

ctrekker commented Jun 7, 2023

Strangely everything works just fine when I look at it with a debugger....

@fonsp
Copy link
Member

fonsp commented Jun 8, 2023 via email

ctrekker added a commit that referenced this issue Jun 13, 2023
@ctrekker
Copy link
Member Author

This is only a bug on the precomputed sliders PR. In the latest commit it should be fixed there!

@Pangoraw
Copy link
Member

This look likes fonsp/Pluto.jl#2427 so maybe the bug is only on 1.9.

@ctrekker
Copy link
Member Author

This look likes fonsp/Pluto.jl#2427 so maybe the bug is only on 1.9.

I bet that's it! That looks like pretty much an identical bug, and the issue was fixed after I updated Pluto from 0.19.9 to >=0.19.19 in the slider server project toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants