Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark background for TOC #193

Merged
merged 4 commits into from
Mar 5, 2022
Merged

Dark background for TOC #193

merged 4 commits into from
Mar 5, 2022

Conversation

pankgeorg
Copy link
Member

@pankgeorg pankgeorg commented Jan 21, 2022

No description provided.

@github-actions
Copy link

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/JuliaPluto/PlutoUI.jl", rev="toc-dark-mode")
julia> using PlutoUI

Or run this code in your browser: Run with binder

@pankgeorg pankgeorg changed the title Update TableOfContents.jl Dark background for TOC Jan 21, 2022
@pankgeorg pankgeorg mentioned this pull request Jan 22, 2022
@icweaver
Copy link
Contributor

This is awesome, thanks for working on this Panagiotis! Not sure if this is the right place, but I was wondering if the "Edit or run this notebook" button could also get a little TLC?

Screenshot from 2022-01-22 11-15-51

I'd be happy to start a PR for this to get the ball rolling if it doesn't require too much Pluto magic 🪄

@fonsp
Copy link
Member

fonsp commented Jan 24, 2022

hmmmmmm but this is using Pluto's internal CSS variables! Weren't you the one who told me that widget authors surely won't use those and create their own CSS variables?

@fonsp
Copy link
Member

fonsp commented Jan 24, 2022

@icweaver well spotted! That button is part of Pluto itself, but it is a bit difficult to work on because you can only see it on the export output, which uses Pluto's CSS from the last release... You either have to set up a local file server to replace the pluto CDN while developing (or you just okay I decided to just quickly fix this instead :) fonsp/Pluto.jl@1119602

@pankgeorg
Copy link
Member Author

hmmmmmm but this is using Pluto's internal CSS variables!
yes!

Weren't you the one who told me that widget authors surely won't use those and create their own CSS variables?

I said that widget authors can override those while using them on their own styles! Take a look at this, where I do exactly that :)

@icweaver
Copy link
Contributor

icweaver commented Mar 4, 2022

Was hoping to bump this. It looks so good!

@fonsp fonsp merged commit ef6cd4f into main Mar 5, 2022
@fonsp fonsp deleted the toc-dark-mode branch March 5, 2022 21:09
@icweaver
Copy link
Contributor

icweaver commented Mar 5, 2022

thank-you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants