Migrate from BinDeps to BinaryBuilder / JLL #40
Conversation
* Remove `BinDeps` and `Homebrew` dependencies (fixes JuliaPolyhedra#38) * Add `lrslib_jll` dependency * Delete `deps/` (it's no longer used)
…th its Polyhedra.jl parent
JuliaPolyhedra/LRSLib.jl#40 CI is passing on version [0.1.0+3](JuliaPackaging#2862) of `lrslib_jll`, and fails on earlier versions due to the lack of an `liblrsnash` LibraryProduct. AFAIK, Julia package compatibility [specifiers](https://pkgdocs.julialang.org/v1/compatibility/) don't have a way of saying "version 0.1.0+3 or above," so we need a version bump to be able to require at least this version in LRSLib.jl's `Project.toml` (see JuliaPolyhedra/LRSLib.jl#40). Since this release adds more API (in the form of the new LibraryProduct), I think a bump to the [minor version](https://semver.org/#spec-item-7) makes sense, i.e., to `v"0.2.0"`
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
- Coverage 83.77% 83.70% -0.08%
==========================================
Files 8 8
Lines 635 632 -3
==========================================
- Hits 532 529 -3
Misses 103 103
Continue to review full report at Codecov.
|
|
Oh actually, looks like those builds were already broken. Ok, I'll call this ready for review 🙂 |
JuliaPolyhedra/LRSLib.jl#40 CI is passing on version [0.1.0+3](#2862) of `lrslib_jll`, and fails on earlier versions due to the lack of an `liblrsnash` LibraryProduct. AFAIK, Julia package compatibility [specifiers](https://pkgdocs.julialang.org/v1/compatibility/) don't have a way of saying "version 0.1.0+3 or above," so we need a version bump to be able to require at least this version in LRSLib.jl's `Project.toml` (see JuliaPolyhedra/LRSLib.jl#40). Since this release adds more API (in the form of the new LibraryProduct), I think a bump to the [minor version](https://semver.org/#spec-item-7) makes sense, i.e., to `v"0.2.0"`
|
@blegat / @oyamad, could we revisit whether it's worth merging this change now, rather than waiting for the more involved changes of JuliaPolyhedra/lrslib#4? Some of my colleagues are blocked (or have to do pretty drastic workarounds) on dependency issues that boil down to this package's dependence on now-unmaintained Homebrew.jl. |
|
Sorry, I thought I had merged this. Of course, it's better not to wait. This is already a major improvement over the current release |
|
Awesome, thanks @blegat! |
Summary
Fixes #39.
BinDepsandHomebrewdependencies (fixes Homebrew failing on travis #38)lrslib_jlldependencydeps/(it's no longer used)