Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eltype for some iterators is incorrect #7

Closed
tkoolen opened this issue Feb 13, 2017 · 1 comment
Closed

eltype for some iterators is incorrect #7

tkoolen opened this issue Feb 13, 2017 · 1 comment

Comments

@tkoolen
Copy link
Contributor

tkoolen commented Feb 13, 2017

vr = SimpleVRepresentation([1 2; 3 4])

for p in points(vr)
    println(typeof(p))
end

prints (as expected):

Array{Int64,1}
Array{Int64,1}

However,

eltype(points(vr))

is Int64.

This causes issues with collect(points(vr)), for example.

Same for rays, possibly others.

Thanks for the great library by the way!

blegat added a commit that referenced this issue Feb 17, 2017
@blegat
Copy link
Member

blegat commented Feb 17, 2017

Thanks for the feedback. This should be fixed in #11 CDDLib needs to be updated too since it used eltype on iterators as a feature, this if fixed in JuliaPolyhedra/CDDLib.jl#8, I will wait before Polyhedra is tagged before merging it but you can checkout to the branch eltypeit if you do not want to wait :) Polyhedra's new tag won't happen before #6 is fixed.

@blegat blegat closed this as completed in 54dc86c Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants