Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove API: Try.throw #20

Merged
merged 1 commit into from
Mar 20, 2022
Merged

Remove API: Try.throw #20

merged 1 commit into from
Mar 20, 2022

Conversation

tkf
Copy link
Member

@tkf tkf commented Mar 20, 2022

It's essentially equivalent to Try.unwrap. Let's minimize API for now.

It's essentially equivalent to `Try.unwrap`. Let's minimize API for now.
@tkf tkf enabled auto-merge (squash) March 20, 2022 14:07
@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #20 (0140672) into main (9f74ff6) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   55.93%   55.93%           
=======================================
  Files           8        8           
  Lines         236      236           
=======================================
  Hits          132      132           
  Misses        104      104           
Flag Coverage Δ
Pkg.test 55.93% <66.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Try.jl 75.00% <ø> (ø)
src/core.jl 48.78% <66.66%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@tkf tkf merged commit dee441d into main Mar 20, 2022
@tkf tkf deleted the api branch March 20, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant