Don't steal reference from existing Python object #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, good catch! |
|
Can you audit the other usages of It seems like it would be cleaner to define: pyptr(x) = pystealref!(PyObject(x))
pyptr(x::PyObject) = pyincref_(x.o)and then call |
|
I grepped |
tkf
commented
Sep 1, 2018
| wrapping/converted from `x` is created. | ||
| """ | ||
| pyreturn(x::Any) = pystealref!(PyObject(x)) | ||
| pyreturn(x::PyObject) = pyincref_(x.o) |
There was a problem hiding this comment.
I named it pyreturn since I thought that's more intuitive. Of course, it is super easy to replace it to pyptr.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #551
I'm not very familiar with Python C API but I think this fixes the bug.