Make PyCall.jl AOT-compilable #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
Feb 27, 2019
| empty!(pycall_gc) | ||
| empty!(pyexc) | ||
| empty!(pytype_queries) | ||
| empty!(permanent_strings) |
stevengj
reviewed
Feb 27, 2019
|
|
||
| write(joinpath(@__DIR__, "_julia_path"), Base.julia_cmd().exec[1]) | ||
|
|
||
| @info "System image: $pysysout" |
There was a problem hiding this comment.
This all seems like boilerplate — why does PyCall.jl need a custom compile.jl file? Can't PackageCompiler automate this?
There was a problem hiding this comment.
Snoop in PackageCompiler does not work due to JuliaLang/julia#31156 (a bug in Julia?). There is another "latent" issue JuliaLang/PackageCompiler.jl#192. I think PackageCompiler is still rather a moving target so using lower-level API with a bit of boilerplate makes sense. Another upside is that we can control exactly what functions are included in system image by tweaking code in aot/precompile.jl (although it is rather sparse and random ATM).
|
Rebuilt after #671: https://travis-ci.org/JuliaPy/PyCall.jl/builds/511789604 (all green) |
tkf
added a commit
to tkf/PyCall.jl
that referenced
this pull request
May 19, 2019
In PR JuliaPy#651, I introduced code to empty `npy_api` in `__init__` but forgot to reset `npy_initialized`. This introduces a bug if `npyinitialize` is called during sysimage compilation (`--output-o` mode) because the main body of `npyinitialize` is not run at run-time.
tkf
added a commit
to tkf/PyCall.jl
that referenced
this pull request
May 19, 2019
In PR JuliaPy#651, I introduced code to empty `npy_api` in `__init__` but forgot to reset `npy_initialized`. This introduces a bug if `npyinitialize` is called during sysimage compilation (`--output-o` mode) because the main body of `npyinitialize` is not run at run-time.
tkf
added a commit
that referenced
this pull request
May 20, 2019
) In PR #651, I introduced code to empty `npy_api` in `__init__` but forgot to reset `npy_initialized`. This introduces a bug if `npyinitialize` is called during sysimage compilation (`--output-o` mode) because the main body of `npyinitialize` is not run at run-time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes PyCall.jl compatible with PackageCompiler.jl and add some tests.
Quick usage:
Slightly more detailed docs in: aot/README.md