Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NumPy 2.1 (only) #550

Open
PallHaraldsson opened this issue Sep 5, 2024 · 2 comments
Open

Support NumPy 2.1 (only) #550

PallHaraldsson opened this issue Sep 5, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@PallHaraldsson
Copy link
Contributor

Going forward you likely want to support NumPy 2.0 (some breaking changes), and I think users can choose it already. 2.1 is out.

Since you support NumPy expliclity, do some of the changes concern you, such as:

np.float32(3) + 3. now returns a float32 when it previously returned a float64.

@PallHaraldsson PallHaraldsson added the enhancement New feature or request label Sep 5, 2024
@cjdoris
Copy link
Collaborator

cjdoris commented Sep 5, 2024

Is there a specific issue here? Is PythonCall not compatible with numpy 2?

@PallHaraldsson
Copy link
Contributor Author

It probably is like any other Python package is. It's just it seems you have special support for NumPy, so I'm not sure. Going forward, I assume most will want to use latest 2.x, and if you allow any NumPy, then it's inconsistent if you get Float32 back or Float64 with the older version, and Julia might be sensitive to that? [Also e.g. NumPy now has 64-bit integers on all platforms, including Windows, but had 32-bit integers before on 64-bit Windows.]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants