Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point users to PythonCall.jl #556

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Point users to PythonCall.jl #556

merged 2 commits into from
Mar 20, 2024

Conversation

MilesCranmer
Copy link
Collaborator

@MilesCranmer MilesCranmer commented Feb 13, 2024

@mkitti What do you think? Currently there is nothing pointing users to PythonCall.jl besides comments in GitHub issues. A new user might see this repository having more stars => preferred/stable option, despite PythonCall.jl being the one that is actively maintained.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ab68f4) 87.52% compared to head (27dea0c) 79.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
- Coverage   87.52%   79.60%   -7.92%     
==========================================
  Files          39       39              
  Lines        2349     2349              
==========================================
- Hits         2056     1870     -186     
- Misses        293      479     +186     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkitti
Copy link
Member

mkitti commented Feb 14, 2024

I think we should involve a lot more people before proceeding with this.

@MilesCranmer
Copy link
Collaborator Author

Fair enough but this has already happened in the various GH issues (eg #555 (comment), #542 (comment)).

I don’t see a reason it shouldn’t also be mentioned on the README so users don’t accidentally use unmaintained software. Why should they need to post an issue before we tell them to use PythonCall?

@jlapeyre
Copy link

jlapeyre commented Mar 5, 2024

It seems clear to me that a link the PythonCall would be useful.

You could debate about what should be said about the two projects. But just about anything is better than nothing.
The text of this PR looks ok to me.

@MilesCranmer
Copy link
Collaborator Author

Seems people are happy with this in https://discourse.julialang.org/t/deprecate-pyjulia-in-favor-of-py-juliacall/111634. Are we good to merge @mkitti? I wouldn't consider this an 'official deprecation' but just a helpful pointer. Maybe I could say

- interface has transitioned to PythonCall.jl
+ interface has mostly transitioned to PythonCall.jl

to be even more explicit that this is not an official deprecation, if you would like?

@jlapeyre
Copy link

Just to reiterate and agree with @MilesCranmer . The main points should be easy and not contentious. Add text to landing pages, particularly those with high search visibility that give links to related projects with a bit of context. And this PR hits the main point.

The question of in some sense deprecating pyjulia and anything else that requires any amount of real work can easily be postponed.

Ideally all of the julia/python interface repos should have a section similar to this one

@mkitti mkitti merged commit f30de4e into master Mar 20, 2024
11 of 24 checks passed
@mkitti mkitti deleted the MilesCranmer-patch-1 branch March 20, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants