-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor for v0.1.5
#59
Conversation
Codecov ReportBase: 61.16% // Head: 70.74% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 61.16% 70.74% +9.57%
==========================================
Files 21 24 +3
Lines 1146 1234 +88
==========================================
+ Hits 701 873 +172
+ Misses 445 361 -84
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a massive PR! Congratulations!
I left behind a couple comments which are more questions that I had. Feel free to ignore them but maybe out of them some improvements might appear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some more comments behind, mainly with questions and requests to open Issues based on code TODOs. Besides typos, a few comments I made during the last round need to be addressed.
Since this PR is required for the manuscript, please address the comments from @joaquimg and maybe @AndradeTiago and @pedroripper can drop a review as well.
This PR closes #60 |
Open comments were moved to #63 and JuliaQUBO/QUBOTools.jl#34. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very happy with this PR. I left a couple of comments behind but they are just small details for future PRs or removing emojis (sorry for being boring).
Congrats!
This PR aims to close #58, close #45, close #31 and close #20.