Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for v0.1.5 #59

Merged
merged 38 commits into from
Feb 15, 2023
Merged

Refactor for v0.1.5 #59

merged 38 commits into from
Feb 15, 2023

Conversation

pedromxavier
Copy link
Member

This PR aims to close #58, close #45, close #31 and close #20.

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2023

Codecov Report

Base: 61.16% // Head: 70.74% // Increases project coverage by +9.57% 🎉

Coverage data is based on head (51ffe74) compared to base (787aa28).
Patch coverage: 71.67% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   61.16%   70.74%   +9.57%     
==========================================
  Files          21       24       +3     
  Lines        1146     1234      +88     
==========================================
+ Hits          701      873     +172     
+ Misses        445      361      -84     
Impacted Files Coverage Δ
src/compiler/architectures.jl 50.00% <0.00%> (ø)
src/lib/pbo/print.jl 0.00% <0.00%> (ø)
src/model/prequbo.jl 0.00% <ø> (ø)
src/attributes/model.jl 25.00% <25.00%> (ø)
src/lib/pbo/wrapper.jl 8.69% <33.33%> (ø)
src/attributes/solver.jl 48.97% <48.97%> (ø)
src/lib/pbo/tools.jl 66.66% <58.33%> (+3.40%) ⬆️
src/attributes/compiler.jl 59.83% <59.83%> (ø)
src/lib/pbo/quadratization.jl 64.00% <64.28%> (-3.80%) ⬇️
src/model/wrapper.jl 77.77% <72.00%> (+5.31%) ⬆️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@bernalde bernalde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a massive PR! Congratulations!
I left behind a couple comments which are more questions that I had. Feel free to ignore them but maybe out of them some improvements might appear.

docs/src/booklet.md Show resolved Hide resolved
docs/src/examples/knapsack.md Show resolved Hide resolved
docs/src/manual.md Show resolved Hide resolved
src/attributes/compiler.jl Show resolved Hide resolved
src/compiler/constraints.jl Outdated Show resolved Hide resolved
src/lib/pbo/quadratization.jl Show resolved Hide resolved
src/model/qubo.jl Outdated Show resolved Hide resolved
src/model/wrapper.jl Show resolved Hide resolved
test/examples/integer/integer_primes.jl Show resolved Hide resolved
test/examples/logical/logical_sos.jl Outdated Show resolved Hide resolved
docs/src/examples/prime_factorization.md Show resolved Hide resolved
src/attributes/compiler.jl Outdated Show resolved Hide resolved
src/attributes/compiler.jl Outdated Show resolved Hide resolved
src/lib/pbo/quadratization.jl Outdated Show resolved Hide resolved
test/examples/logical/logical_tsp.jl Outdated Show resolved Hide resolved
@pedromxavier pedromxavier self-assigned this Feb 3, 2023
Copy link
Collaborator

@bernalde bernalde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some more comments behind, mainly with questions and requests to open Issues based on code TODOs. Besides typos, a few comments I made during the last round need to be addressed.
Since this PR is required for the manuscript, please address the comments from @joaquimg and maybe @AndradeTiago and @pedroripper can drop a review as well.

src/attributes/compiler.jl Outdated Show resolved Hide resolved
src/compiler/compiler.jl Outdated Show resolved Hide resolved
src/compiler/constraints.jl Outdated Show resolved Hide resolved
src/compiler/constraints.jl Outdated Show resolved Hide resolved
src/compiler/constraints.jl Outdated Show resolved Hide resolved
src/compiler/variables.jl Outdated Show resolved Hide resolved
src/lib/pbo/PBO.jl Outdated Show resolved Hide resolved
src/lib/pbo/quadratization.jl Show resolved Hide resolved
src/lib/pbo/quadratization.jl Outdated Show resolved Hide resolved
src/model/wrapper.jl Show resolved Hide resolved
@pedromxavier
Copy link
Member Author

This PR closes #60

@pedromxavier pedromxavier mentioned this pull request Feb 14, 2023
12 tasks
@pedromxavier
Copy link
Member Author

Open comments were moved to #63 and JuliaQUBO/QUBOTools.jl#34.

Copy link
Collaborator

@bernalde bernalde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very happy with this PR. I left a couple of comments behind but they are just small details for future PRs or removing emojis (sorry for being boring).
Congrats!

src/compiler/build.jl Outdated Show resolved Hide resolved
src/compiler/variables.jl Show resolved Hide resolved
src/compiler/variables.jl Outdated Show resolved Hide resolved
@pedromxavier pedromxavier merged commit bfbfeab into master Feb 15, 2023
@pedromxavier pedromxavier deleted the px/refactor branch February 15, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add stable quadratization Virtual Model Attributes Variable Encoding Quadratization
5 participants