-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write Docs for v0.1.5
#64
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #64 +/- ##
=======================================
Coverage 70.56% 70.56%
=======================================
Files 24 24
Lines 1247 1247
=======================================
Hits 880 880
Misses 367 367
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely PR; some things to be added in the comments, but if it is not perfect, it is alright. Documentation is a never-ending story.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of typos, but more importantly, I do not know if we should use an image of the D-Wave chip (especially if we do not have copyrights on it). I would rather remove it.
We took the image from wikimedia commons. I think we should have, if not this one, at least a figure to motivate and catch people's attention with shiny alien-like hardware. |
@bernalde we found this image on Wikimedia, so it should be copyright free. But I feel that it is not contributing to the documentation too much. I can remove if you all agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
I could not find the Wikipedia picture of the DWave chip, but I found this other one https://commons.wikimedia.org/wiki/File:DWave_128chip.jpg that has the CC3 License such that we can use it. If you wanna keep the current image, just make sure about the license it has (Wikipedia provides those details)
I had to comment these lines because the different dispatches for |
Is this ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some typos here and there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree; this is ready to merge (there is some warning regarding CodeCov integration, should we look into this?)
I'll just review if we have checked everything from #63 |
This PR aims to close #63.