Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Docs for v0.1.5 #64

Merged
merged 42 commits into from
Apr 20, 2023
Merged

Write Docs for v0.1.5 #64

merged 42 commits into from
Apr 20, 2023

Conversation

pedromxavier
Copy link
Member

This PR aims to close #63.

@pedromxavier pedromxavier added the documentation Improvements or additions to documentation label Feb 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3e37e5c) 70.56% compared to head (65b0441) 70.56%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   70.56%   70.56%           
=======================================
  Files          24       24           
  Lines        1247     1247           
=======================================
  Hits          880      880           
  Misses        367      367           
Impacted Files Coverage Δ
src/attributes/compiler.jl 59.83% <ø> (ø)
src/compiler/constraints.jl 85.55% <ø> (ø)
src/lib/pbo/quadratization.jl 64.00% <ø> (ø)
src/compiler/architectures.jl 50.00% <100.00%> (ø)
src/model/virtual.jl 87.36% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@bernalde bernalde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely PR; some things to be added in the comments, but if it is not perfect, it is alright. Documentation is a never-ending story.

docs/make.jl Outdated Show resolved Hide resolved
docs/src/booklet/2-qubo.md Show resolved Hide resolved
docs/src/booklet/5-virtual.md Outdated Show resolved Hide resolved
docs/src/booklet/6-solvers.md Outdated Show resolved Hide resolved
docs/src/booklet/6-solvers.md Outdated Show resolved Hide resolved
docs/src/booklet/6-solvers.md Outdated Show resolved Hide resolved
docs/src/booklet/6-solvers.md Outdated Show resolved Hide resolved
docs/src/booklet/6-solvers.md Outdated Show resolved Hide resolved
docs/src/manual/2-model.md Outdated Show resolved Hide resolved
docs/src/manual/3-results.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@bernalde bernalde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of typos, but more importantly, I do not know if we should use an image of the D-Wave chip (especially if we do not have copyrights on it). I would rather remove it.

README.md Outdated Show resolved Hide resolved
docs/src/booklet/2-qubo.md Outdated Show resolved Hide resolved
docs/src/booklet/2-qubo.md Outdated Show resolved Hide resolved
docs/src/booklet/3-pbo.md Outdated Show resolved Hide resolved
docs/src/index.md Outdated Show resolved Hide resolved
src/lib/pbo/quadratization.jl Outdated Show resolved Hide resolved
src/lib/pbo/quadratization.jl Outdated Show resolved Hide resolved
src/lib/pbo/quadratization.jl Outdated Show resolved Hide resolved
@pedromxavier
Copy link
Member Author

pedromxavier commented Feb 17, 2023

There are a couple of typos, but more importantly, I do not know if we should use an image of the D-Wave chip (especially if we do not have copyrights on it). I would rather remove it.

We took the image from wikimedia commons. I think we should have, if not this one, at least a figure to motivate and catch people's attention with shiny alien-like hardware.

@pedroripper
Copy link
Member

There are a couple of typos, but more importantly, I do not know if we should use an image of the D-Wave chip (especially if we do not have copyrights on it). I would rather remove it.

@bernalde we found this image on Wikimedia, so it should be copyright free. But I feel that it is not contributing to the documentation too much. I can remove if you all agree

Copy link
Collaborator

@bernalde bernalde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!
I could not find the Wikipedia picture of the DWave chip, but I found this other one https://commons.wikimedia.org/wiki/File:DWave_128chip.jpg that has the CC3 License such that we can use it. If you wanna keep the current image, just make sure about the license it has (Wikipedia provides those details)

docs/src/booklet/2-qubo.md Outdated Show resolved Hide resolved
@pedroripper
Copy link
Member

I had to comment these lines because the different dispatches for ToQUBO.toqubo_constraint weren't showing up on the docs.
Does anyone know how to solve this?

https://github.com/psrenergy/ToQUBO.jl/blob/e56193c93d10ad18d8b191dc157f577d9d8de63f/src/compiler/interface.jl#L57-L61

@bernalde
Copy link
Collaborator

Is this ready to merge?

Copy link
Collaborator

@bernalde bernalde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hunt down any mention of Anneal.jl.
I have a question, why do the subsections in the booklet not show up in the navigation bar? I feel that most of the contents of this documentation are hidden
image

docs/src/booklet/7-solvers.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@bernalde bernalde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos here and there

docs/src/booklet/2-qubo.md Outdated Show resolved Hide resolved
docs/src/booklet/2-qubo.md Outdated Show resolved Hide resolved
docs/src/booklet/2-qubo.md Outdated Show resolved Hide resolved
docs/src/booklet/2-qubo.md Outdated Show resolved Hide resolved
docs/src/booklet/2-qubo.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@bernalde bernalde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree; this is ready to merge (there is some warning regarding CodeCov integration, should we look into this?)

@pedroripper
Copy link
Member

I'll just review if we have checked everything from #63

@pedromxavier pedromxavier merged commit ac8be79 into master Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write Docs
4 participants