Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Yahoo Finance API breaks pull #98

Closed
DDoyle1066 opened this issue Sep 7, 2024 · 0 comments · Fixed by #99
Closed

New Yahoo Finance API breaks pull #98

DDoyle1066 opened this issue Sep 7, 2024 · 0 comments · Fixed by #99

Comments

@DDoyle1066
Copy link

Good description of the issue is here

I think the change needs to happen in the downloads.jl file for the yahoo function and should look something like:

host = "query2"#rand(["query1", "query2"])
url = "https://$host.finance.yahoo.com/v8/finance/chart/$sym"
@assert res.status == 200
json_arr = JSON3.read(res.body)
full_dict = merge(json_arr.chart.result[1].indicators.quote[1],
  json_arr.chart.result[1].indicators.adjclose[1],
  Dict(:timestamp => DateTime.(json_arr.chart.result[1].timestamp)))
named_tup = NamedTuple(Dict([k=>Array(v) for (k,v) in full_dict]))

However, the timestamp is all in integers and I couldn't find a way to convert it to the DateTime that TimeArray is expecting

Arkoniak pushed a commit to Arkoniak/MarketData.jl that referenced this issue Sep 9, 2024
Arkoniak added a commit that referenced this issue Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant