Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes missing values in fred() being string #84

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

dwinrow
Copy link
Contributor

@dwinrow dwinrow commented Apr 4, 2022

Apologies, the previous pull #82 ended up reverting #81 when merged but shouldn't have.

Fixes #79

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #84 (b8bf7eb) into master (cbeb769) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b8bf7eb differs from pull request most recent head 1864f42. Consider uploading reports for the commit 1864f42 to get more accurate results

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files           4        4           
  Lines          58       58           
=======================================
  Hits           54       54           
  Misses          4        4           
Impacted Files Coverage Δ
src/downloads.jl 92.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbeb769...1864f42. Read the comment docs.

small syntax fix
@Arkoniak Arkoniak merged commit aaddc35 into JuliaQuant:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FRED missing data represented by "."
2 participants