Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AbstractOptimizationResult #78

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

goerz
Copy link
Member

@goerz goerz commented Sep 16, 2024

This allows for more seamless conversion between the result objects of different methods. To convert between two result types, the first result is converted to a Dict of field names to values, and then that dict is converted to the target result type. This assumes that all result types have a common set of field names, and for any field in a result that is not in that common set, a custom convert method must be defined that sets default values for those fields in the target result type.

This allows for more seamless conversion between the result objects of
different methods. To convert between two result types, the first result
is converted to a Dict of field names to values, and then that dict is
converted to the target result type. This assumes that all result types
have a common set of field names, and for any field in a result that is
not in that common set, a custom convert method must be defined that
sets default values for those fields in the target result type.
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.6%. Comparing base (71b6197) to head (b18e3e2).

Files with missing lines Patch % Lines
src/result.jl 93.2% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master     #78     +/-   ##
========================================
+ Coverage    88.5%   88.6%   +0.2%     
========================================
  Files          19      20      +1     
  Lines        1001    1030     +29     
========================================
+ Hits          885     912     +27     
- Misses        116     118      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goerz goerz merged commit 5ce75c3 into master Sep 16, 2024
5 checks passed
@goerz goerz deleted the abstract-optimization-result branch September 16, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant