Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sdp and polynomial interface #83

Merged
merged 4 commits into from
Jun 15, 2022
Merged

update sdp and polynomial interface #83

merged 4 commits into from
Jun 15, 2022

Conversation

lucaferranti
Copy link
Member

This PR updates SDP and the polynomial interface

  • There was some boilerplate code in SDP, no need to differentiate between 1D and higher dimension, also no need to allocate the vector Bi, a generator can be used
  • Now _enclose(SumOfSquaresEnclosure) expects as a second input a polynomial instead of a function, this makes sense, because SOS works only for polynomials and the previous implementation was converting the function to polynomial. This change allows to avoid using the @polyvar macro, which is polynomial backend specific, this way we can only use the interface package MultivariatePolynomials.jl as dependency.
  • removed DynamicPolynomials.jl as dependecy as replaced with MultivariatePolynomials.jl which is now optional (fixes replace DynamicPolynomials.jl by MultivariatePolynomials.jl #68)

@lucaferranti lucaferranti requested review from schillic and mforets June 14, 2022 21:26
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I have one question.

Co-authored-by: Christian Schilling <git@christianschilling.net>
@schillic schillic merged commit 9a6d340 into master Jun 15, 2022
@schillic schillic deleted the lf-polynomials branch June 15, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace DynamicPolynomials.jl by MultivariatePolynomials.jl
3 participants