update sdp and polynomial interface #83
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates SDP and the polynomial interface
_enclose(SumOfSquaresEnclosure)
expects as a second input a polynomial instead of a function, this makes sense, because SOS works only for polynomials and the previous implementation was converting the function to polynomial. This change allows to avoid using the@polyvar
macro, which is polynomial backend specific, this way we can only use the interface packageMultivariatePolynomials.jl
as dependency.DynamicPolynomials.jl
as dependecy as replaced withMultivariatePolynomials.jl
which is now optional (fixes replaceDynamicPolynomials.jl
byMultivariatePolynomials.jl
#68)