Let continuous post return input options #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mforets
reviewed
Mar 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #539 +/- ##
==========================================
+ Coverage 60.57% 60.66% +0.08%
==========================================
Files 35 35
Lines 1537 1543 +6
==========================================
+ Hits 931 936 +5
- Misses 606 607 +1
Continue to review full report at Codecov.
|
schillic
force-pushed
the
schillic/options_in_output
branch
from
58092d7
to
45d01f9
Compare
schillic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation crashes when trying to plot the result for a purely-continuous system. The problem was that we return a
TwoLayeredOptionsin the result, and that is not allowed in the plot recipe.I decided to wrap the resulting options in anOptionsstructure again here.