Do not project automatically for :projection_matrix option #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mforets
approved these changes
Mar 16, 2019
There was a problem hiding this comment.
I was thinking to delete the call to project inside post altogether, do it in the upper level solve! instead.
But maybe this is just fine, since projection is algorithm-specific in general (for example depends on the way the flowpipe is represented: e.g. if it consists of concrete zonotopes => i may want to use linear_map for the projection, instead of LinearMap -> overapproximate). A workaround is then to call project from solve! but allow algorithms to extend the function project for their use case.
|
I do not propose to keep it here. We can still outsource later. But in any case we want to remove that disjunct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.