-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#668 - Replace inout_map by low-dimensional flowpipes #676
Conversation
9b6aad1
to
618e05d
Compare
618e05d
to
5097fca
Compare
i guess you mean full dimensional |
There's also the related issue #541 but we can do on a follow-up PR. |
This changeset does not work with the way we implemented the hybrid algorithm. We need to discuss this. |
54843e6
to
7dc19cf
Compare
The last commit solved it again. It is certainly a workaround but I think overall the state has improved 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Closes #668.
Summary:
SparseReachSet
which behaves like aReachSet
but additionally stores the dimensions in which it was computed (from now on, aReachSet
must always be high dimensional).AbstractReachSet
forReachSet
andAbstractReachSet
with the methodsset
,time_start
,time_end
, andproject
. Theproject
method just receives a projection matrix.SparseReachSet
flowpipes, which consists of two steps:compute_dimensions
to compute the dimensions forSparseReachSet
s (currently this function resides inBFFPSV18
).SparseReachSet
s.project
/project_reach
:AbstractReachSet
individually.CartesianProduct
with the time interval.inout_map
from reachability algorithms (it still exists for properties, which can maybe be refactored another time).Some of the benchmarks in https://github.com/JuliaReach/ReachabilityBenchmarks need to be updated (because we access some
ReachSet
fields explicitly 👎).