Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#639 - Reachability for LTI systems with interval matrices using zonotopes #681

Merged
merged 5 commits into from
Sep 11, 2019

Conversation

schillic
Copy link
Member

@schillic schillic commented Sep 9, 2019

Closes #639.

Requires: JuliaReach/IntervalMatrices.jl#52, JuliaReach/LazySets.jl#1681

The unit test is the example 1 from the paper. Computing the result is quick, but plotting the zonotopes takes ages. I plotted the result for :max_order => 3 (which is fast).

@schillic schillic requested a review from mforets September 9, 2019 16:13
@mforets
Copy link
Member

mforets commented Sep 9, 2019

I plotted the result for :max_order => 3 (which is fast).

👍 We can let the default value be 3 or 4..

Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 🎉

@schillic
Copy link
Member Author

schillic commented Sep 9, 2019

We can let the default value be 3 or 4..

Hm, we could offer a post-processing at some point, but for checking properties the order 3 is too small. Let's keep it for now and maybe change it later.

@schillic
Copy link
Member Author

Nice job! 🎉

Not sure if that was clear, but we first need to incorporate changes in IntervalMatrices and LazySets (I updated the first comment), so your reviewing job is not done yet 😢

@schillic schillic merged commit 13a006d into master Sep 11, 2019
@schillic schillic deleted the schillic/639 branch September 11, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reachability for LTI systems with interval matrices using zonotopes
2 participants