Revise order reduction in GLGM06 #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this PR still applies or it was superseded by a more recent one? |
schillic
force-pushed
the
schillic/homogeneous
branch
from
dc37595 to
12be071
Compare
schillic
changed the title
schillic
force-pushed
the
schillic/homogeneous
branch
from
12be071 to
14610b8
Compare
mforets
approved these changes
May 23, 2020
schillic
force-pushed
the
schillic/homogeneous
branch
from
14610b8 to
bd62cb4
Compare
schillic
force-pushed
the
schillic/homogeneous
branch
from
bd62cb4 to
4026dfc
Compare
|
I rethought this and actually there is no need to change the behavior. In the homogeneous case it still makes sense to reduce the order of |
mforets
approved these changes
May 23, 2020
schillic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally this PR should just remove the order reduction in a homogeneous
GLGM06run.But then I hit a wall that the newLazySetsv1.32 is incompatible with our flowpipes consisting of sets of fixed type (because the type may change during the analysis).This PR adds a brute-force conversion forGLGM06but some work would be needed for other algorithms as well.(The conversion after order reduction might be redundant.)