Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Manopt v0.4.61 #105725

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

JuliaRegistrator
Copy link
Contributor

### Added

* Tests now also use `Aqua.jl` to spot problems in the code, e.g. ambiguities.
* introduce a feature-based list of solvers and reduce the details in the alphabetical list
* adds a `PolyakStepsize`
* added a `get_subgradient` for `AbstractManifoldGradientObjectives` since their gradient is a special case of a subgradient.

### Fixed

* `get_last_stepsize` was defined in quite different ways that caused ambiguities. That is now internally a bit restructured and should work nicer.
  Internally this means that the interims dispatch on `get_last_stepsize(problem, state, step, vars...)` was removed. Now the only two left are `get_last_stepsize(p, s, vars...)` and the one directly checking `get_last_stepsize(::Stepsize)` for stored values.
* we accidentally exported `set_manopt_parameter!`, this is now fixed.

### Changed

* `get_manopt_parameter` and `set_manopt_parameter!` have been revised and better documented,
  they now use more semantic symbols (with capital letters) instead of direct field access
  (lower letter symbols). Since these are not exported, this is considered an internal, hence non-breaking change.
  * semantic symbols are now all nouns in upper case letters
  * `:active` is changed to `:Activity`

UUID: 0fc0a36-df90-57f3-8f93-d78a9fc72bb5
Repo: https://github.com/JuliaManifolds/Manopt.jl.git
Tree: bea838472cbf318487e1cc6643208bbe27eeffdb

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
JuliaRegistrator referenced this pull request in JuliaManifolds/Manopt.jl Apr 27, 2024
* Fix typos in symbol table to get parameters.
* Implement Polyak stepsize
* Tests PolyakStepsize.
* update changelog.
* add a literature reference

---------

Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
Copy link
Contributor

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@JuliaTagBot JuliaTagBot merged commit 36f88cf into master Apr 27, 2024
17 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-manopt-0fc0a36d-v0.4.61-dffeeb90c3 branch April 27, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants