Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Manopt v0.4.64 #108549

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

JuliaRegistrator
Copy link
Contributor

### Added

* Remodel the constraints and their gradients into separate `VectorGradientFunctions`
  to reduce code duplication and encapsulate the inner model of these functions and their gradients
* Introduce a `ConstrainedManoptProblem` to model different ranges for the gradients in the
  new `VectorGradientFunction`s beyond the default `NestedPowerRepresentation`
* introduce a `VectorHessianFunction` to also model that one can provide the vector of Hessians
  to constraints
* introduce a more flexible indexing beyond single indexing, to also include arbitrary ranges
  when accessing vector functions and their gradients and hence also for constraints and
  their gradients.

### Changed

* Remodel `ConstrainedManifoldObjective` to store an `AbstractManifoldObjective`
  internally instead of directly `f` and `grad_f`, allowing also Hessian objectives
  therein and implementing access to this Hessian
* Fixed a bug that Lanczos produced NaNs when started exactly in a minimizer, since we divide by the gradient norm.

### Deprecated

* deprecate `get_grad_equality_constraints(M, o, p)`, use `get_grad_equality_constraint(M, o, p, :)`
  from the more flexible indexing instead.

UUID: 0fc0a36d-df90-57f3-8f93-d78a9fc72bb5
Repo: https://github.com/JuliaManifolds/Manopt.jl.git
Tree: 6ee3a798eeeeca7bbe7dfdb05360b0d16e16f3af

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
JuliaRegistrator referenced this pull request in JuliaManifolds/Manopt.jl Jun 8, 2024
* Start structural rework on constraint objectives.
* Sketch the idea of a unified vector function objective.
* Fix tests.
* A bit of vale.
* Update Changelog.
* Sketch Hessian vector function.
* add type upper bounds to ConstrainedManifoldObjective
* Apply suggestions from code review
* minor improvements

---------

Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
Copy link
Contributor

github-actions bot commented Jun 8, 2024

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@JuliaTagBot JuliaTagBot merged commit 0f0be96 into master Jun 8, 2024
17 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-manopt-0fc0a36d-v0.4.64-dffeeb90c3 branch June 8, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants