Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: AstroCoords v0.1.0 #115646

Merged

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 27fb9038-6a9d-4e07-8d5d-d0805b53c4cb
Repo: https://github.com/jmurphy6895/AstroCoords.jl.git
Tree: a45888da3867771f796a6df7ce1e390e7378596c

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Copy link
Contributor

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines are all met! ✅

Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

3. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@goerz
Copy link
Member

goerz commented Sep 21, 2024

[noblock] There's a typo in the project name in the documentation:

CleanShot 2024-09-21 at 16 20 43@2x

Shouldn't the content of the "Library" page be on the "API" page? There's also something going on with the formatting of the docstrings… but anyway: something to work on, but not essential for the initial registration.

@aplavin
Copy link
Contributor

aplavin commented Sep 22, 2024

Not familiar with satellite trajectory calculations, just got curious when seeing the package name :)
I wonder if there's any potential for interop with/reuse parts of JuliaAstro/SkyCoords.jl?
[noblock]

@jmurphy6895
Copy link

[noblock] @aplavin It looks like that package is more for defining measurements/objects from a ground station perspective, so it could be used for something like measurements of these states for filtering purposes, I'm planning on adding support for something like that in a future package so I'll be sure to keep this one in mind!

@JuliaTagBot JuliaTagBot merged commit ad46df5 into master Sep 24, 2024
17 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-astrocoords-27fb9038-v0.1.0-97d6b6c89d branch September 24, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants