Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: CoordGridTransforms v0.1.0 #120627

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Dec 3, 2024

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines are all met! ✅

Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

3. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@goerz
Copy link
Member

goerz commented Dec 4, 2024

Could you add just a little bit more documentation in the README to explain how exactly this can be used? Maybe it's extremely obvious to users of CoordRefSystems, but adding a paragraph of explanation of how CoordGridTransforms acts as an "extension" still seems like a good idea

[noblock]

UUID: 1cf1ec0c-22f7-4062-925b-8db09db48fc3
Repo: https://github.com/JuliaEarth/CoordGridTransforms.jl.git
Tree: 527bb5a8201480dfc543b1582f709a4e915fa1d8

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-coordgridtransforms-1cf1ec0c-v0.1.0-169a33a3b1 branch from 7c4a458 to 06871c1 Compare December 4, 2024 16:54
JuliaRegistrator referenced this pull request in JuliaEarth/CoordGridTransforms.jl Dec 4, 2024
@eliascarv
Copy link

@goerz done!

[noblock]

@eliascarv
Copy link

eliascarv commented Dec 6, 2024

@goerz why is the registration blocked? Any other pending issues?

[noblock]

@goerz
Copy link
Member

goerz commented Dec 6, 2024

[noblock] What makes you say that it's blocked?

As the bot says:

Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

That waiting period elapses in a few hours, so it will be merged then

@eliascarv
Copy link

Oh sorry, I got confused when I saw "Merging is blocked" in the PR.

Captura de tela de 2024-12-06 15-49-03

[noblock]

@goerz
Copy link
Member

goerz commented Dec 6, 2024

[noblock] That just means you do not have the permissions to merge this manually (nor do I)

@JuliaTagBot JuliaTagBot merged commit c2af075 into master Dec 6, 2024
9 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-coordgridtransforms-1cf1ec0c-v0.1.0-169a33a3b1 branch December 6, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants