Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: ManifoldsBase v0.15.23 #121046

Merged

Conversation

JuliaRegistrator
Copy link
Contributor

### Added

* a field `point` to `ValidationFibreVector` to potentially store the point of the vector.
* a field `store_base_point` to `ValidationManifold` to indicate whether for new fibre vectors the base point should be stored.
* a keyword `ignore_contexts` to `ValidationManifold` to ignore certain contexts from validation, such as `:Input`, `:Output`, `:Point`, or `:Vector`.
* a keyword `ignore_functions` to `ValidationFibreVector` to ignore certain contexts within a single function. This is provided as a dictionary with the key being the (allocating) function and the value is a context or vector of contexts.

### Changed

* the internal function `array_value` was renamed to `internal_value` and is now exported, since it can be also used on elements that store values different from arrays,
e.g. a `ValidationMPoint` storing a subtype of a `ManifoldPoint`. `array_value` is hence deprecated.
* Minimum Julia version is now 1.10 (the LTS which replaced 1.6)

UUID: 3362f125-f0bb-47a3-aa74-596ffd7ef2fb
Repo: https://github.com/JuliaManifolds/ManifoldsBase.jl.git
Tree: 57df0b7daa74bf82d3367702e133d936c28882ff

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
JuliaRegistrator referenced this pull request in JuliaManifolds/ManifoldsBase.jl Dec 9, 2024
* A first commit updating doc strings, adding the point.
* allow for AbstractMPoints to be in the validation scheme not only arrays.
* Start with the ignores dictionary.
* Unify _msg, add functions from the interface file.
* make _msg also handle errors, hence tests pass again, where two errors gut a bit more precise.
* Debugging and Test coverage.
* Follow the same scheme as Manifolds.jl and make LTS (1.10) the lower bound.
* Remove dependency on Requires.jl, since we raised LTS.
* promote base points on new TVectors.
* also update existing base points if a vector is mutated.
* improve test cov.

---------

Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. AutoMerge Guidelines are all met! ✅

Your new version registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round (~20 minutes).

2. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@JuliaTagBot JuliaTagBot merged commit 750495f into master Dec 9, 2024
15 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-manifoldsbase-3362f125-v0.15.23-9a4155469e branch December 9, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants