-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: AMORS v0.3.1 #125263
base: master
Are you sure you want to change the base?
New package: AMORS v0.3.1 #125263
Conversation
JuliaRegistrator
commented
Feb 17, 2025
- Registering package: AMORS
- Repository: https://github.com/emmt/AMORS.jl
- Created by: @emmt
- Version: v0.3.1
- Commit: fced13e4fc8360927154935d51c3f313bb6ea625
- Reviewed by: @emmt
- Reference: emmt/AMORS.jl@fced13e#commitcomment-152630603
- Description: Framework to apply the AMORS algorithm in Julia
- Release notes:
UUID: 77d29c75-3847-48dd-b74a-66585bbee1d5 Repo: https://github.com/emmt/AMORS.jl.git Tree: b38291aa3a00f7382c0545d2a1704018513dd883 Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human. 1. New package registrationPlease make sure that you have read the package naming guidelines. 2. AutoMerge Guidelines which are not met ❌
3. Needs action: here's what to do next
If you need help fixing the AutoMerge issues, or want your pull request to be manually merged instead, please post a comment explaining what you need help with or why you would like this pull request to be manually merged. Then, send a message to the 4. To pause or stop registrationIf you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text Tip: You can edit blocking comments to add |
|
Unfortunately, acronyms are heavily frowned upon in the Julia community. Personally, I don't have issues with pronounceable acronyms like You will have to go on Slack to convince a full registry maintainer to merge this manually. There seems to be less and less appetite for acronyms, though, so it may require repeated pings. Besides the pronounceability of |
@goerz Thank you for your reply. I could rename the package as How do I cleanly cancel a registration? |
I can override that check. Usually, it's a false positive. What package does In any case, I would make a strong case for
That's definitely an option that would side-step the issue. "Long" is generally encouraged, so that's not a problem. Plus, it's always possible to use it as My recommendation would be – unless you have a preference for
Unmerged registrations are automatically closed after 30 days of inactivity. Or, I can close a PR manually, which I usually do if there's a replacement, e.g., a new package name ("Closing in favor of …") |
Here is the result of the metric: julia> using RegistryCI, RegistryCI.AutoMerge
julia> all_pkg_names = AutoMerge.get_all_non_jll_package_names(joinpath(DEPOT_PATH[1], "registries", "General"));
julia> AutoMerge.meets_distance_check("AMORS", all_pkg_names)
(true, "")
julia> AutoMerge.meets_distance_check("Amors", all_pkg_names)
(false, "Package name similar to 4 existing packages.\n 1. Similar to Amaru. Damerau-Levenshtein distance 2 is at or below cutoff of 2. Normalized visual distance 2.05 is at or below cutoff of 2.50.\n 2. Similar to Kmers. Damerau-Levenshtein distance 2 is at or below cutoff of 2. Normalized visual distance 2.44 is at or below cutoff of 2.50.\n 3. Similar to Attrs. Damerau-Levenshtein distance 2 is at or below cutoff of 2.\n 4. Similar to Actors. Damerau-Levenshtein distance 2 is at or below cutoff of 2.") so it seems that the check is case sensitive.
I think I will follow your advice. Indeed I strongly prefer Many thanks for your help. |