-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set compat for OpenSSL_jll to 1.1.10-1 for OpenSSL_jll v3 transition #78542
Set compat for OpenSSL_jll to 1.1.10-1 for OpenSSL_jll v3 transition #78542
Conversation
Why 1.1.20 and not 1.1.10 as we said the other day on slack? |
This correspond with registry changes here: JuliaRegistries/General#78542
You said 1.1.20 here: |
I think I mistyped 1 for 2 there. |
Fixed. It's now 1.1.10 or higher. |
I'm going to try this again with RetroCap.jl |
O/OpenSSL/Compat.toml
Outdated
@@ -1,10 +1,10 @@ | |||
[1] | |||
BitFlags = "0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd skip this package because this is independent from JuliaPackaging/Yggdrasil#6312. You'd need to coordinate with upstream OpenSSL.jl
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 99e778b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See JuliaWeb/OpenSSL.jl#15 for upstream coordination.
@giordano any other issues? |
We'll see how this goes 🤞 |
Before we build OpenSSL v3 via JuliaPackaging/Yggdrasil#6289 we need to make sure the compat for currently OpenSSL_jll dependencies are bounded to version 1.1.
This pull request also corresponds with JuliaPackaging/Yggdrasil#6312
I examined Deps.toml and Compat.toml for dependence of each package on OpenSSL_jll. If there was a dependence, I added or updated the compat to be "1.1.20-0" for the corresponding versions.
Please review carefully. I used the following code to make the changes.
cc: @giordano